Move golang.org/x/net/context.Context interface implementation check to tests #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Current coverage is 93.05% (diff: 100%)@@ develop #724 diff @@
==========================================
Files 15 15
Lines 1268 1268
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1180 1180
Misses 76 76
Partials 12 12
|
javierprovecho
approved these changes
Dec 4, 2016
Contributor
|
Maybe an exception for the newest go version? Because this got context integrated into the stdlib. |
tboerger
approved these changes
Dec 5, 2016
appleboy
approved these changes
Dec 5, 2016
Member
|
@tboerger for now we are supporting lower versions so the external import must stay. But in the near future or for gin.next we may drop support for older golang versions at once. Do you agree? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only reason to import "golang.org/x/net/context" package is to check that
*gin.Contextimplementscontext.Contextinterface. But this implies fetching whole "golang.org/x/net" package tree usinggo get. So moving this check tocontext_test.gois reasonable.This also resolves issues #469 and #684.