Skip to content

Implement QueryArray and PostFormArray methods #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2016
Merged

Implement QueryArray and PostFormArray methods #570

merged 2 commits into from
Dec 3, 2016

Conversation

@andreynering
Copy link
Contributor

@andreynering andreynering commented Mar 30, 2016

For scenarios like this:

// POST /?[]foo_ids=1&[]foo_ids=3&[]foo_ids=5

c.PostFormArray("[]foo_ids") // []string{"1", "3", "5"}

@coveralls
Copy link

coveralls commented Mar 30, 2016

Coverage Status

Coverage increased (+0.8%) to 94.179% when pulling f3ff8f8 on andreynering:array into 4a6bc4a on gin-gonic:develop.

@appleboy
Copy link
Member

appleboy commented Mar 31, 2016

Nice improvement. 👍

@andreynering andreynering mentioned this pull request Jun 12, 2016
Closed
@appleboy appleboy mentioned this pull request Jun 29, 2016
Closed
@tboerger
Copy link
Contributor

tboerger commented Oct 13, 2016

Normally it's form_name[] for Form values in array format

@andreynering
Copy link
Contributor Author

andreynering commented Oct 13, 2016

Normally it's form_name[] for Form values in array format

It will work either way: form_name[] or []form_name. It actually will work for any name.

tboerger
tboerger approved these changes Dec 2, 2016
View reviewed changes
Copy link
Contributor

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think @appleboy?

appleboy
appleboy approved these changes Dec 3, 2016
View reviewed changes
Copy link
Member

@appleboy appleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@appleboy appleboy merged commit 6f474cb into gin-gonic:develop Dec 3, 2016
@andreynering andreynering deleted the array branch December 3, 2016 10:16
@swrap swrap mentioned this pull request Oct 20, 2019
Closed
@justskiv justskiv mentioned this pull request Feb 12, 2020
Open
@a631807682 a631807682 mentioned this pull request Mar 23, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appleboy appleboy appleboy approved these changes

+1 more reviewer

@tboerger tboerger tboerger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreynering @coveralls @appleboy @tboerger