fix(binding): support query tag in query binding while maintaining form tag backward compatibility #4366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a long-standing issue where
ShouldBindQuery()
only recognizedform
struct tags instead of the more logicalquery
tags, while maintaining full backward compatibility.Problem
The query binding implementation was counterintuitive - when using
c.ShouldBindQuery()
, developers would naturally expect to usequery:"field"
struct tags, but the implementation only recognizedform:"field"
tags:This issue was originally identified in #3235 and fixed in PR #3236, but that fix was reverted in PR #3899 due to backward compatibility concerns.
Solution
The fix introduces a new
mapQuery()
function that supports both tag types:query:"field"
tags (logical and expected)form:"field"
tags (preserves existing code)Changes
queryBinding.Bind()
to use newmapQuery()
function instead ofmapForm()
mapQuery()
function that callsmapFormByTag()
for both "query" and "form" tagsTesting
All existing tests pass and test coverage remains at 99.2%.
Fixes #3235
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.