Skip to content

Conversation

flc1125
Copy link
Contributor

@flc1125 flc1125 commented May 21, 2025

The new configuration was generated using golangci-lint migrate. https://golangci-lint.run/product/migration-guide/#command-migrate

  • Update golangci-lint to version 2
  • Update lint settings across multiple test files
  • Remove unused struct and variable checks

flc1125 added 2 commits May 21, 2025 23:24
- Update golangci-lint to version 2
- Enable new linters and adjust existing ones
- Update lint settings across multiple test files
- Remove unused struct and variable checks
- Add new lint exclusions for generated code and specific directories

Signed-off-by: Flc <[email protected]>
@flc1125 flc1125 marked this pull request as draft May 21, 2025 15:33
@flc1125 flc1125 marked this pull request as ready for review May 21, 2025 15:38
@appleboy appleboy added continuous-integration github_actions Pull requests that update GitHub Actions code labels May 22, 2025
@appleboy appleboy added this to the v1.11 milestone May 22, 2025
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (3dc1cd6) to head (3c15fae).
Report is 122 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4247      +/-   ##
==========================================
- Coverage   99.21%   98.91%   -0.30%     
==========================================
  Files          42       44       +2     
  Lines        3182     3423     +241     
==========================================
+ Hits         3157     3386     +229     
- Misses         17       26       +9     
- Partials        8       11       +3     
Flag Coverage Δ
?
--ldflags="-checklinkname=0" -tags sonic 98.91% <100.00%> (?)
-tags go_json 98.91% <100.00%> (?)
-tags nomsgpack 98.90% <100.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 ?
go-1.23 98.91% <100.00%> (?)
go-1.24 98.91% <100.00%> (?)
macos-latest 98.91% <100.00%> (-0.30%) ⬇️
ubuntu-latest 98.91% <100.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

flc1125 added 3 commits May 22, 2025 19:39
…h 'master' of github.com:gin-gonic/gin into upgrade-golangci-lint
- Remove golang.org/x/lint package from go.mod
- Update related dependencies in go.sum

Signed-off-by: flc1125 <[email protected]>
- Downgrade golang.org/x/mod from v0.24.0 to v0.18.0
- Downgrade golang.org/x/tools from v0.33.0 to v.22.0

These changes are made to address compatibility issues with the current project setup.

Signed-off-by: flc1125 <[email protected]>
@appleboy appleboy merged commit c4287b1 into gin-gonic:master May 23, 2025
24 of 25 checks passed
@flc1125 flc1125 deleted the upgrade-golangci-lint branch May 23, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous-integration github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants