Skip to content

Conversation

@philipc
Copy link
Collaborator

@philipc philipc commented Aug 22, 2025

No description provided.

@philipc philipc merged commit bf70320 into gimli-rs:master Aug 22, 2025
20 checks passed
@philipc philipc deleted the release branch August 22, 2025 10:11
@bugadani
Copy link

I believe this turned out to be a breaking update, see probe-rs/probe-rs#3535 for an automated update PR, with an associated build failure.

@philipc
Copy link
Collaborator Author

philipc commented Aug 25, 2025

Those new PartialEq impls don't even seem to be used. Would you agree that we should remove them and do another patch release?

@bugadani
Copy link

Would you agree that we should remove them

To me, this is always a tricky question. I can't tell why they were introduced, I'm not familiar enough with gimli. I'm not the one to say whether something should be kept or removed - I can only point at a possibly unintended build break :)

I'm personally fine with either rebranding the current state as 0.33, or reverting the breaking parts of the changes and releasing the result as 0.32.2, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants