Skip to content

Conversation

@bladeacer
Copy link
Contributor

No description provided.

@bladeacer bladeacer changed the title Corrected zh.json translations Fix: Corrected zh.json translations May 28, 2025
@gfxholo
Copy link
Owner

gfxholo commented May 28, 2025

Whoa, thank you for the work you've done here! Some of those were pretty big mistranslations.

I'll get back to you about a few of these lines, because some of the corrections are a bit too literal — for example, headingAdvanced is just a heading that says "Advanced", not the actual phrase "Heading Advanced".

I'll target this for the next patch, which should be early next month 💜

@gfxholo gfxholo added this to the 1.1.2 milestone May 28, 2025
@gfxholo
Copy link
Owner

gfxholo commented Jun 13, 2025

Hi again! Some detailed feedback for you now, based on the translation tools I'm using to understand these changes:

Overrule warning

"overrulePrefix": "覆盖前缀",
"overruleSuffix": " 正在覆盖后缀",

These aren't supposed to say "prefix" and "suffix" since those are just string IDs. They should be the first and last halves of this sentence, and the rule name is inserted between them:

#120

Items and buttons

"item": "项目",
"items": "项目",
"appItem": "应用项目",
"appItems": "应用项目",

These shouldn't be literal translations of the string IDs. appItems is supposed to say "buttons", and items is for situations where different types of items (like files and folders) are being selected at once.

Colors

"pink": "粉红色",

✅ This makes sense!

"enterHexCode": "输入一个十六进制代码",

✅ Also good!

"colorIs": "颜色是",
"!colorIs": "颜色不是",

Is this a literal translation of the string ID? colorIs is currently meant to be the same as is. It's always used in a sentence like 颜色 是 粉色.

Settings

"toggleMinimalFolderIcons": "切换极简文件夹图标",

✅ Seems good to me!

"headingAdvanced": "标题高级",

This shouldn't be changed, since the word "heading" is only meant for the string ID.

@bladeacer
Copy link
Contributor Author

I see. The context in which the translations are used certainly clears things up.

@gfxholo
Copy link
Owner

gfxholo commented Jun 15, 2025

I hope it was helpful!

If you want to make any changes, you can still update this PR, and I'll make sure you're credited as the full author.

@bladeacer
Copy link
Contributor Author

Sorry that I am kind of new to this. Do I just commit to my own branch to make changes?

@gfxholo
Copy link
Owner

gfxholo commented Jun 15, 2025

Yup! Just push another commit to bladeacer:main. When I merge your branch, it will become a single commit at the end.

@bladeacer
Copy link
Contributor Author

Thanks. I have updated my branch with the changes.

@gfxholo gfxholo self-assigned this Jun 15, 2025
@gfxholo gfxholo added the language Language corrections for text and menus label Jun 15, 2025
@gfxholo gfxholo merged commit e49fad4 into gfxholo:main Jun 15, 2025
@gfxholo
Copy link
Owner

gfxholo commented Jun 15, 2025

Done! Thanks a bunch for your patience, and for spending your time submitting this. 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

language Language corrections for text and menus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants