-
Notifications
You must be signed in to change notification settings - Fork 32
Fix: Corrected zh.json translations #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Whoa, thank you for the work you've done here! Some of those were pretty big mistranslations. I'll get back to you about a few of these lines, because some of the corrections are a bit too literal — for example, I'll target this for the next patch, which should be early next month 💜 |
|
Hi again! Some detailed feedback for you now, based on the translation tools I'm using to understand these changes: Overrule warning"overrulePrefix": "覆盖前缀",
"overruleSuffix": " 正在覆盖后缀",These aren't supposed to say "prefix" and "suffix" since those are just string IDs. They should be the first and last halves of this sentence, and the rule name is inserted between them: Items and buttons"item": "项目",
"items": "项目",
"appItem": "应用项目",
"appItems": "应用项目",These shouldn't be literal translations of the string IDs. Colors"pink": "粉红色",✅ This makes sense! "enterHexCode": "输入一个十六进制代码",✅ Also good! "colorIs": "颜色是",
"!colorIs": "颜色不是",Is this a literal translation of the string ID? Settings"toggleMinimalFolderIcons": "切换极简文件夹图标",✅ Seems good to me! "headingAdvanced": "标题高级",This shouldn't be changed, since the word "heading" is only meant for the string ID. |
|
I see. The context in which the translations are used certainly clears things up. |
|
I hope it was helpful! If you want to make any changes, you can still update this PR, and I'll make sure you're credited as the full author. |
|
Sorry that I am kind of new to this. Do I just commit to my own branch to make changes? |
|
Yup! Just push another commit to |
|
Thanks. I have updated my branch with the changes. |
|
Done! Thanks a bunch for your patience, and for spending your time submitting this. 💚 |
No description provided.