Add "deprecated" flag to query runners (and alert destinations) #3972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related #3805. |
added 4 commits
July 22, 2019 09:20
…uery runners when adding a new data source
…ted alert destinations when adding a new alert destination
rauchy
commented
Jul 22, 2019
| } | ||
|
|
||
|
|
||
| @deprecated() |
There was a problem hiding this comment.
@arikfr not sure you actually wanted to deprecate this (and the URL data source) as part of this PR, so let me know if you want me to revert this commit.
There was a problem hiding this comment.
No, it's cool. We do need to update the docs about the URL data source though.
There was a problem hiding this comment.
The page currently mixes JSON and URL and feels like it might need a slight rewrite (or some good chunks related to URL removed). WDYT @susodapop?
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
…edash#3972) * add a deprecated flag to query runners and show only non-deprecated query runners when adding a new data source * add a deprecated flag to alert destinations and show only non-deprecated alert destinations when adding a new alert destination * add a deprecated() decorator for a more succint way to deprecate * deprecate URL query runner and HipChat alert destination * use class properties instead of class methods for deprecation * I <3 newlines
This was referenced Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated Query Runners/Alert Destinations will not show up in the list of available types when creating a new one, but will remain there for those data sources/destinations that use them already.
This is useful to deprecate the URL data source and HipChat alert destinations.