Skip to content

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Jun 6, 2019

What type of PR is this? (check all applicable)

  • Feature

Description

  1. Changed Test Connection to try and open a spreadsheet to verify that credentials actually work.
  2. Show friendlier message when receiving an API error:
Before After
image image

@arikfr arikfr merged commit 1630cbb into master Jun 12, 2019
@arikfr arikfr deleted the gs-friendly-error branch June 12, 2019 08:47
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
…ore reliable test connection (getredash#3883)

* Google Sheets: friendlier error message in case of an APIError and more reliable test connection.

* Pleasing the pep8 gods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant