Skip to content

Edit parameter mapping: error when trying to change mapping type to Static; cannot change static value #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2019
Merged

Edit parameter mapping: error when trying to change mapping type to Static; cannot change static value #3800

merged 2 commits into from
May 14, 2019

Conversation

kravets-levko
Copy link
Collaborator

@kravets-levko kravets-levko commented May 14, 2019 •
edited
Loading

What type of PR is this? (check all applicable)

  • Bug Fix

Description

  1. When editing parameter mapping for query-based parameter, changing it's type to static shows error in console: image Solution: pass required property to component.
  2. Cannot change parameter mapping's static value (bug in data flow between components).
  3. Some cleanup (removed unused properties).

@kravets-levko kravets-levko requested a review from ranbena May 14, 2019 13:31
@kravets-levko kravets-levko self-assigned this May 14, 2019
ranbena
ranbena reviewed May 14, 2019
View reviewed changes
Copy link
Contributor

@ranbena ranbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is gone 👍
The dropdown works BUT it keeps showing the default value even after selecting another.

@kravets-levko
Copy link
Collaborator Author

@ranbena Thanks! I think it's another bug, I'll check.

@kravets-levko kravets-levko changed the title Edit parameter mapping: error when trying to change mapping type to Static Edit parameter mapping: error when trying to change mapping type to Static; cannot change static value May 14, 2019
@kravets-levko
Copy link
Collaborator Author

@ranbena Looks that bug wasn't related to mentioned error message, but it was definitely a bug. Now fixed.

@kravets-levko kravets-levko requested a review from ranbena May 14, 2019 13:58
ranbena
ranbena approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@ranbena ranbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥

@kravets-levko kravets-levko merged commit b9b30a3 into master May 14, 2019
@kravets-levko kravets-levko deleted the bug/parameter-mapping-editor-change-type-error branch May 14, 2019 16:17
@weekly-digest weekly-digest bot mentioned this pull request May 20, 2019
Closed
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@kravets-levko @harveyrendell
[Bug fix] Edit parameter mapping: error when trying to change mapping…
2fe2fed 
… type to Static; cannot change static value (getredash#3800)

* Edit parameter mapping: error when trying to change mapping type to Static

* Parameter mapping editor: cannot change static value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ranbena ranbena ranbena approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kravets-levko kravets-levko

Labels

Bug Frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kravets-levko @ranbena