Dashboard Grid #3 - Auto Height #3749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
commented
Apr 30, 2019
|
|
||
| start = () => { | ||
| this.stop(); | ||
| this.interval = setInterval(this.checkHeightChanges, INTERVAL); |
There was a problem hiding this comment.
@kravets-levko Eventually implemented with polling cause ResizeObserver turned out to be not a good fit - complex when observing multiple elements per widget.
ranbena
commented
Apr 30, 2019
ranbena
commented
Apr 30, 2019
| margin={[cfg.margins, cfg.margins]} | ||
| isDraggable={this.props.isEditing} | ||
| isResizable={this.props.isEditing} | ||
| onResizeStart={this.autoHeightCtrl.stop} |
There was a problem hiding this comment.
When widget is manually resized, interval is paused and then resumed to avoid "height fights" and also better perf.
ranbena
commented
Apr 30, 2019
| return reduce(els, (acc, el) => { | ||
| const height = el ? el.getBoundingClientRect().height : 0; | ||
| return acc + height; | ||
| }, 0); |
There was a problem hiding this comment.
PS I would like to eventually move away from checking multiple element heights - with the right HTML/CSS changes, the same look and functionality can be implemented with observation of a single element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ported the auto height feature
Included:
Mobile & Desktop Screenshots/Recordings
🔔 Red stripe indicator on top is for local testing purposes only. Not in prod. 🔔
Auto resizes on update
Manual resize revokes auto height