Skip to content

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Apr 24, 2019

  • Refactor

Description

Ported the dual column modes - multi and single with an 800px breakpoint.

Included:

  • Support for multiple layouts with breakpoints
  • Toggle isGridDisabled - "Done Editing" button disabled in single column mode
  • Tested that public dashboard works
  • Related tests unskipped and passing

Notice

Because of an issue with react-grid-layout regarding order of event triggers, I put in a temp workaround till it's fixed.

Mobile & Desktop Screenshots/Recordings

@ranbena ranbena self-assigned this Apr 24, 2019
@ranbena ranbena added the Frontend: React Frontend codebase migration to React label Apr 24, 2019
@ranbena ranbena removed the request for review from kravets-levko April 24, 2019 17:00
@ranbena ranbena changed the title Dashboard Grid #2 - Single Column layout Dashboard Grid #2 - Single Column layout wip Apr 24, 2019
@ranbena ranbena changed the title Dashboard Grid #2 - Single Column layout wip Dashboard Grid #2 - Single Column layout Apr 25, 2019
@ranbena ranbena requested a review from kravets-levko April 25, 2019 09:53
@kravets-levko kravets-levko merged commit 6425c56 into 1-grid-migration May 3, 2019
@kravets-levko kravets-levko deleted the 2-single-col branch May 3, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend: React Frontend codebase migration to React

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants