Fix Ability to Add Query-based Parameters to Existing Queries #3716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 17, 2019 11:38
… might still not be associated with the parent. see #3711
added 6 commits
April 28, 2019 13:44
…alidate it. parent query association checks are sufficient
…h nested ACL even if they aren't associated yet (given that the user has _direct_ access to the dropdown query)
arikfr
reviewed
May 5, 2019
redash/handlers/query_results.py
Outdated
| abort(403) | ||
| dropdown_query = get_object_or_404(models.Query.get_by_id_and_org, dropdown_query_id, self.current_org) | ||
| if not has_access(dropdown_query.data_source, current_user, view_only): | ||
| abort(403) |
There was a problem hiding this comment.
Check the CodeClimate error -- it's actually relevant.
There was a problem hiding this comment.
I'm surprised Flask didn't crash on this 😝
added 2 commits
May 6, 2019 09:37
Just like it used to be, but only now it will fallback on the backend and still allow dropdown query results, even when they are unassociated (assuming user has direct access to the dropdown query). |
arikfr
reviewed
May 12, 2019
redash/handlers/query_results.py
Outdated
| if int(dropdown_query_id) not in related_queries_ids: | ||
| abort(403) | ||
| dropdown_query = get_object_or_404(models.Query.get_by_id_and_org, dropdown_query_id, self.current_org) | ||
| if not has_access(dropdown_query.data_source, current_user, view_only): |
There was a problem hiding this comment.
Can't we use require_access here as well?
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
…ash#3716) * propagate `isDirty` down to `QueryBasedParameterInput` * go to /api/:id/dropdown while editing a query, since dropdown queries might still not be associated with the parent. see getredash#3711 * show helpful error message if dropdown values cannot be fetched * use backticks instead of line concatenation * remove requirement to have direct access to dropdown query in order validate it. parent query association checks are sufficient * remove isDirty-based implementation and allow dropdown queries through nested ACL even if they aren't associated yet (given that the user has _direct_ access to the dropdown query) * fix tests to cover all cases for /api/queries/:id/dropdowns/:id * fix indentation * require access to the query, not the data source * use require_access instead of has_access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
In order to solve #3711, dropdown values would be fetched directly from the
/api/:id/dropdownendpoint while a query is edited. Once it is saved, an association is created and dropdown values could be fetched from/api/:parent_id/dropdowns/:id.If a user has edit privileges to the parent query but cannot access the dropdown query directly, he will be prompted with this message:
Related Tickets & Documents
Fixes #3711
Mobile & Desktop Screenshots/Recordings (if there are UI changes)