Skip to content

(WIP) SystemStatus query runner (get Redash system status using SQL) #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

(WIP) SystemStatus query runner (get Redash system status using SQL) #3584

wants to merge 2 commits into from

Conversation

kravets-levko
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Feature
  • New Query Runner (Data Source)

Description

I haven't been sleeping and decided to try myself in creating query runners. This is just an experiment inspired by #3568 (comment)

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image

image

@kravets-levko kravets-levko self-assigned this Mar 14, 2019
@ghost ghost added the in progress label Mar 14, 2019
@ranbena
Copy link
Contributor

ranbena commented Mar 14, 2019

So awesome! 🤩

ranbena
ranbena reviewed Mar 14, 2019
View reviewed changes
Copy link
Contributor

@ranbena ranbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually, not sure this should be a new query runner cause it contains actual data.
Perhaps it should be a "built-in" data source (query runner - url, source - "/api/system_status").

@arikfr
Copy link
Member

arikfr commented Mar 14, 2019

@ranbena

Conceptually, not sure this should be a new query runner cause it contains actual data.

Interesting definition, but I'm not sure the fact it provides its own data disqualifies it from being a query runner on its own.

Having said that, it will be useful if this data source could connect to remote instances as well. The only change is to load the data from the /status.json API instead of reading directly. Then in the data source configuration it can take a URL and API key.

@kravets-levko
Copy link
Collaborator Author

kravets-levko commented Mar 14, 2019 •
edited
Loading

Another +1 for using data source for system status: it will obey common ACL rules. Current /status.json is hard-locked to admins only and cannot be shared with other users; if making that URL available to all - it couldn't be restricted. With data source it becomes really flexible: we can add it by default when setting up Redash instance, but make it available only for admin group; if somebody wants - he can share it with other users.

@kravets-levko
Copy link
Collaborator Author

Added an example how it could be used to retrieve celery workers status:

image

@kravets-levko kravets-levko changed the title SystemStatus query runner (get Redash system status using SQL) (WIP) SystemStatus query runner (get Redash system status using SQL) Mar 14, 2019
@kravets-levko kravets-levko deleted the system-status branch May 1, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arikfr arikfr Awaiting requested review from arikfr

@rauchy rauchy Awaiting requested review from rauchy

1 more reviewer

@ranbena ranbena ranbena left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kravets-levko kravets-levko

Labels

Backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kravets-levko @ranbena @arikfr