Skip to content

Migrate Dashboards/Queries/Users list pages to React #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Feb 5, 2019
Merged

Migrate Dashboards/Queries/Users list pages to React #3381

merged 40 commits into from
Feb 5, 2019

Conversation

kravets-levko
Copy link
Collaborator

@kravets-levko kravets-levko commented Jan 31, 2019 •
edited
Loading

  • Create new base component based on /lib/list-ctrl.js (which is a common parent for mentioned pages);
  • Migrate Dashboards list page;
  • Migrate Queries list page;
  • Migrate Users list page;
    • Error handling
    • <users-list-extra>
  • Cleanup.

Screenshots:

image

image

image

image

image

image

image

@kravets-levko kravets-levko added Frontend Frontend: React Frontend codebase migration to React labels Jan 31, 2019
@kravets-levko kravets-levko self-assigned this Jan 31, 2019
@ghost ghost added the in progress label Jan 31, 2019
qlty-cloud-legacy[bot]
qlty-cloud-legacy bot reviewed Jan 31, 2019
View reviewed changes
@arikfr
Copy link
Member

arikfr commented Jan 31, 2019

Have you considered using Ant's component instead of a table for these pages?

@jezdez
Copy link
Contributor

jezdez commented Jan 31, 2019

@kravets-levko Could we please merge #2888 first since there is some overlap with the routes refactor there?

jezdez
jezdez reviewed Jan 31, 2019
View reviewed changes
@arikfr
Copy link
Member

arikfr commented Jan 31, 2019

@jezdez

@kravets-levko Could we please merge #2888 first since there is some overlap with the routes refactor there?

Yes, I'll merge yours first. (Sorry, Levko...)

@ranbena
Copy link
Contributor

ranbena commented Jan 31, 2019

@kravets-levko Great to see Ant Table and page titles change by context 👍🏻

Only noticed that the favorite icon in first table column is misaligned. Perhaps the column is missing a specific width?

@ranbena
Copy link
Contributor

ranbena commented Jan 31, 2019

Have you considered using Ant's component

What did you have in mind @arikfr ?

ranbena
ranbena reviewed Jan 31, 2019
View reviewed changes
@kravets-levko
Copy link
Collaborator Author