Frontend: fix boolean field with null value display as null. #2523
Conversation
client/app/lib/value-format.js
Outdated
There was a problem hiding this comment.
Shouldn't we use empty string instead of 'null', like we do for numeric columns? And, BTW, here should be check for undefined too (the same as below)
client/app/lib/value-format.js
Outdated
There was a problem hiding this comment.
Please remove this empty line
d0725c8 to
138c081
Compare
138c081 to
ad0a981
Compare
|
@kravets-levko @arikfr sorting as defined in dynamic table is: // ASC -> DESC -> off sorting ASC: note that the caret shows DESC order (I would expect to see the triangle flipped ^ ) looks like the order sign is flipped redash/client/app/components/dynamic-table/dynamic-table.html Lines 10 to 15 in 414faba And the issue now with the ASC sorting is that it breaks: Order should be |
|
hi @innovia! it's because we use "raw" values for sorting. it's different issue (we already noticed it with number columns and null values), and it's not directly related to this PR. we'll fix it soon too, but for now let's merge your fix 😉 |
|
What about the caret direction? Seems like its fliiped |
|
cc: @kocsmy |
|
@arikfr please review |
|
I'd just follow the same as we use on our main nav: |
|
On the nav it makes sense as it opens and close but it doesnt make sense on
a sorting of asc/desc
|
|
Oh sorry, I misunderstood this :) ASC: triangle pointing up, DESC: triangle pointing down. |
No description provided.