Assets serving changes #2296
Merged
Assets serving changes #2296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… make sure all assets URLs are prefixed with /static/ and remove our custom assets serving handler.
webpack.config.js
Outdated
| new CopyWebpackPlugin([ | ||
| { from: 'client/app/assets/robots.txt' }, | ||
| { from: 'client/app/assets/css/login.css', to: 'styles/login.css' }, | ||
| { from: 'client/app/assets/js/jquery.min.js', to: 'js/jquery.min.js' }, |
There was a problem hiding this comment.
Do we really need to store jquery.min.js in app/assets folder? We already have jquery and all pre-built bundles in node_modules
There was a problem hiding this comment.
Probably not. But then we need to create a new entry point that will export only jQuery?
There was a problem hiding this comment.
Can you try to replace from path with node_modules/jquery/dist/jquery.min.js? Will it work?
kravets-levko
approved these changes
Feb 8, 2018
|
Thanks!
It's been long overdue. Next thing can be to create a dedicated login page CSS, but maybe it's better to load the large one to save download time on the next page? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to the way we serve assets:
/static/.Breaking change:
REDASH_STATIC_ASSETS_PATHis a single value again and no longer supports multiple paths.Might help with #2209.