Additional documentation #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/setup.rst
Outdated
There was a problem hiding this comment.
Only on AWS it's ubuntu. On GCE they add the users you setup in their management console.
There was a problem hiding this comment.
@arikfr Leaving it as it is now because the GCE section is just after and I don't think users will be confused.
There was a problem hiding this comment.
👍 Sorry, I forgot this section is in the context of AWS only.
|
Thanks! I really appreciate the effort to improve documentation. |
|
@arikfr Updated the documentation thanks to your comments. I've also squashed commits |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly coming from https://gist.github.com/arikfr/9d061bedb55ccd137f30 and this is hopefully just a start to a great and complete documentation!
If you want me to add something before merging this, don't hesitate. I'm not familiar with everything in your Gist so a quick explanation would be awesome ;)