Skip to content

Add link to embeds to open query page in new window #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2016
Merged

Add link to embeds to open query page in new window #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion rd_ui/app/views/visualization-embed.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ <h3 class="panel-title">
<span class="label label-default">Updated: <span am-time-ago="queryResult.getUpdatedAt()"></span></span>

<span class="pull-right">
<a class="btn btn-default btn-xs" ng-disabled="!queryResult.getData()" query-result-link target="_self">
<a class="btn btn-default btn-xs" ng-href="/queries/{{visualization.query.id}}#{{visualization.id}}" target="_blank" tooltip="Open in re:dash">
<span class="glyphicon glyphicon-link"></span>
</a>
<a class="btn btn-default btn-xs" ng-disabled="!queryResult.getData()" query-result-link target="_self" tooltip="Download as CSV">
<span class="glyphicon glyphicon-cloud-download"></span>
</a>
</span>
Expand All @@ -29,3 +32,5 @@ <h3 class="panel-title">
</div>
</div>
</div>


2 changes: 1 addition & 1 deletion redash/handlers/embed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def embed(query_id, visualization_id, org_slug=None):

qr = project(qr, ('data', 'id', 'retrieved_at'))
vis = project(vis, ('description', 'name', 'id', 'options', 'query', 'type', 'updated_at'))
vis['query'] = project(vis, ('created_at', 'description', 'name', 'id', 'latest_query_data_id', 'name', 'updated_at'))
vis['query'] = project(vis['query'], ('created_at', 'description', 'name', 'id', 'latest_query_data_id', 'name', 'updated_at'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 oops.


return render_template("embed.html",
name=settings.NAME,
Expand Down