Hide dashboards that current user cannot see based on his groups #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2016
arikfr
added a commit
that referenced
this pull request
Apr 20, 2016
Hide dashboards that current user cannot see based on his groups
|
I've added a few more tests and merged. Thank you! Btw, I'm wondering if we should enforce this when trying to access the dashboard directly (with the URL)? |
|
@yanenok note that this includes your work as well, so thank you both! |
|
@arikfr |
|
The title might leak information, but I guess it's not that big of a deal. Will leave as is for now. |
simo7
pushed a commit
to pubnative/redash
that referenced
this pull request
Sep 22, 2016
getredash#957 has been merged.
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Hide dashboards that current user cannot see based on his groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is based on #878
The difference is that text widgets are public. And i also added some tests.