Require vars.DOCKER_REPOSITORY to publish image #7400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow user arikfr to publish images to redash/redash and redash/preview. Only use vars.DOCKER_USER and secrets.DOCKER_PASSWORD for authorization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
To allow user arikfr to publish images to redash/redash and redash/preview. Only use
vars.DOCKER_USERandsecrets.DOCKER_PASSWORDfor authorization.2025.01 was the last preview image published at https://hub.docker.com/u/redash becuse the repository was assumed to be based on the docker username. (See https://github.com/getredash/redash/actions/runs/14184394211/job/39737590514)
How is this tested?
https://github.com/eradman/redash/actions/runs/14250088861
Related Tickets & Documents
GitHub Settings