Doesn't it change a behavior? We should use Link component for all internal links

<Link> should throw a type error if it gets a click handler. This was sort of a workaround. I'm trying to think in a more general solution to this.

<Link> has some logic that allows to modify URL. Using <Button> here will break those links in Databricks internal fork

I do not agree that link should throw a type error if it gets a click handler.

It's valid to have a link perform one behavior when you click on it, and another if you middle click / open in a new tab (for example, if you want to open a modal, you don't want to refresh the page when you left click, but you do want a new page with the modal if you open a link to it in a new tab).

The problem in this case is for pieces of code like this:

In practice, this component is sometimes a link and sometimes a button, which hurts its accessibility. If everything were typescript this wouldn't be a problem, as an href is required by <Link>. Ideally we would need to have a custom component that renders a <button> for cases like this one, or add keyboard handlers. Please let me have your opinion on this.

When Step component has a link - it can have either urlText + onClick or urlText + url + urlTarget. You can use this to decide what to render - link or button. Also, you could even update TS types to indicate this:

type StepCommonProps = { ... };

type StepLinkProps = {
  urlText: string;
  url: string;
  urlTarget: string;
}

type StepButtonProps = {
  urlText: string;
  onClick: ...;
}

type StepProps = StepCommonProps & (StepLinkProps | StepButtonProps);

In this case when you'll try to render <Step> component with onClick - TS will not allow you to use url and urlTarget, and if you'll add url and/or urlTarget - it will forbid onClick

Update: see #5435

This change feels bigger than the others. Can you summarize what the expected changes are to the schema browser?

Changes expected are basically none. Just refactored the styles to make it easier to work with, as many of the positionings were done in a workaround-like manner. There were bugs as well: I've changed the way tooltips are positioned upon these components to make it a11y (and UI overall) friendly.

Quick summary of the changes:

• Improved nesting
• Decoupled the button to open the drawer with the one that adds it to the editor
• Updated the box sizing to flexbox to achieve the same result more consistently
• Used flexbox to center, in place of paddings and margins
• Reduced repetition re-structuring how classes are set
• Added focus feedback
• Added transition
• TODO (not tracked): render of drawer has no transition

I do not agree that link should throw a type error if it gets a click handler.

It's valid to have a link perform one behavior when you click on it, and another if you middle click / open in a new tab (for example, if you want to open a modal, you don't want to refresh the page when you left click, but you do want a new page with the modal if you open a link to it in a new tab).

Why Link type="link"?