Replace <a> and <button> with <PlainButton> (round 1)
#5421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
210f6e6 to
e2ee89f
Compare
963d0c7 to
fd23521
Compare
<a> and <button> with <PlainButton><a> and <button> with <PlainButton> (round 1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR is a split on #5409
This PR follows on #5418, #5419, #5420
It is the fourth step to fix issues on standardization, interactivity and improve keyboard accessibility.
This aims to clean all remaining
<a>and<button>and replace it with own semantic buttons. There should be no visual changes.The following behavior for links, buttons, link-like and button-like components is aimed:
<Link>- Renders<a><Button>- Renders Antd<Button><Link.Button>- Renders Antd<Button>, which is rendered as an<a><PlainButton>- Renders styleless<button>Note for reviewers:
Commits start at c8caa7f and are grouped as