-
Notifications
You must be signed in to change notification settings - Fork 4.5k
React migration cleanup #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React migration cleanup #4572
Conversation
} | ||
|
||
/* light version of bootstrap's form-control */ | ||
.rd-form-control { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual change, the rest is from Prettier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one comment on useMemo
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get rid of the dead weight. 👍
@arikfr While working on this PR I briefly checked the usage of Bootstrap components - looks that there's really no much left as well. But I decided to not touch it for now. |
@kravets-levko good call. It's probably better to do in a separate PR anyway. I have a feeling we mostly use different helper classes ( |
We mostly use helper classes (which are actually not a part of Bootstrap - mostly), and somewhere - grid. I didn't see any Boostrap components usages (like alerts/panels/etc.) - probably I missed something because that wasn't my target at that time (I was reviewing a lot of files for other purpose and checked this just by the way), but there are really no much left. And a lot of icons of course 🙂 |
I wonder if there is some utility we can use to analyze our code and tell us which styles are actually in use? |
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)