Skip to content

Conversation

kravets-levko
Copy link
Collaborator

@kravets-levko kravets-levko commented Jan 21, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Other

Description

  • Revisit ANGULAR_REMOVE_ME things
  • Remove unused CSS (probably not 100% cleanup, but at least remove ones that are not used for sure)
  • Revisit error handling flow (how HTTP and promise rejection errors are handled)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@kravets-levko kravets-levko added Frontend Frontend: React Frontend codebase migration to React labels Jan 21, 2020
@kravets-levko kravets-levko self-assigned this Jan 21, 2020
@kravets-levko kravets-levko changed the title Revisit ANGULAR_REMOVE_ME things React migration cleanup Jan 21, 2020
}

/* light version of bootstrap's form-control */
.rd-form-control {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual change, the rest is from Prettier

@kravets-levko kravets-levko marked this pull request as ready for review January 22, 2020 13:37
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one comment on useMemo.

Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of the dead weight. 👍

@kravets-levko
Copy link
Collaborator Author

@arikfr While working on this PR I briefly checked the usage of Bootstrap components - looks that there's really no much left as well. But I decided to not touch it for now.

@kravets-levko kravets-levko merged commit cbc5626 into master Jan 22, 2020
@kravets-levko kravets-levko deleted the react-migration-cleanup branch January 22, 2020 15:15
@arikfr
Copy link
Member

arikfr commented Jan 22, 2020

@kravets-levko good call. It's probably better to do in a separate PR anyway. I have a feeling we mostly use different helper classes (m-l-5 and friends), grid and some "component" classes (like panes and such), which probably have an alternative in Ant.

@kravets-levko
Copy link
Collaborator Author

We mostly use helper classes (which are actually not a part of Bootstrap - mostly), and somewhere - grid. I didn't see any Boostrap components usages (like alerts/panels/etc.) - probably I missed something because that wasn't my target at that time (I was reviewing a lot of files for other purpose and checked this just by the way), but there are really no much left. And a lot of icons of course 🙂

@arikfr
Copy link
Member

arikfr commented Jan 22, 2020

I wonder if there is some utility we can use to analyze our code and tell us which styles are actually in use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend: React Frontend codebase migration to React Frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants