Fix Redash 8 requirements... #4287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but we just merged in Python 3 support into master. So I guess this is no longer relevant? |
|
That's why it's a merge into the redash 8 branch, or are you saying that
redash 8 final will be python 3? (woohoo!).
I'd assumed it would be redash 9 as the first p3 release.
Chris
…On Thu, 24 Oct 2019, 12:31 Arik Fraimovich, ***@***.***> wrote:
Thanks, but we just merged in Python 3 support into master. So I guess
this is no longer relevant?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4287?email_source=notifications&email_token=ACBATFL6VHTINYUJZACVJOTQQGBQDA5CNFSM4JER7CHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEWNFA#issuecomment-545875604>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBATFOY6A4VDJCI6FWEJYDQQGBQDANCNFSM4JER7CHA>
.
|
|
Sorry, didn't notice it's a merge into the v8 branch. No, v8 is finished and stays Python 2 :-) Still not sure as to what to do about this PR, as I was hoping not to touch the v8 branch (unless some critical issues needs fixing). 🤔 |
|
I updated the 8.0.x branch and had to force push into it. Can you please rebease on top of the latest version? Thanks. |
…ndas to allow clean install against vanilla Python 2.7.17
a32187d to
ad3b24a
Compare
|
Done; I think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to $REASONS I've found myself deploying Redash against fresh builds of Python 2.7.17 with nothing else installed and have run across a couple of problems.
This change bumps pymssql to a version that builds cleanly (with fix for pymssql/issues/520) and clamps the pandas package (a dependency of pymapd) to a version that doesn't require python 3.