Skip to content

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Oct 22, 2019

  • Refactor

Description

  1. Deduped the delete menu by supplying <MenuButton /> to AlertView and AlertEdit.
  2. Added menu button "loading" state.

There is no change in functionality.
This is a preparation for alert on/off toggle feature.

Screenshots

@ranbena ranbena marked this pull request as ready for review October 22, 2019 09:06
@ranbena ranbena requested a review from kravets-levko October 22, 2019 09:06
@ranbena ranbena self-assigned this Oct 22, 2019
Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@ranbena ranbena merged commit 3dfad87 into master Oct 22, 2019
@guidopetri guidopetri deleted the alert-menu-button branch July 22, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants