[P-1182] identify should only emit an event when address is detected #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-1182 SDK: identify should only emit an event when address is detected
Too many events, and too similar to detect wallet event |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the FormoAnalytics class so that the identify event is only emitted when a valid address is detected.
- Removed the branch that called identify with a null address
- Aligns the event emission with the requirement specified in P-1182
Contributor
Author
|
Not published yet |
HnngFormo
approved these changes
Apr 21, 2025
TamHuynhTee
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.