- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
[P-1139] [P-1130] [P-1138] Add detect_wallet action, refactor identify function #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          P-1139 session.isIdentified check does not handle multiple identify calls in the same session
 Currently the session is identified after the first  What happens if in the same session there are are multiple identify calls: 
 Will the second call be skipped?   /**
   * Emits an identify event with current wallet address.
   * param {Address} params.address
   * returns {Promise<void>}
   */
  public async identify({
    address,
    providerName,
    rdns,
  }: {
    address: Address | null;
    providerName?: string;
    rdns?: string;
  }): Promise<void> {
    if (this.session.isIdentified())
      return logger.warn("Identify: Wallet already identified in this session");
    this.session.identify();
    await this.trackEvent(Event.IDENTIFY, {
      address,
      providerName,
      rdns,
    });
  }P-1130 Event seconds are not recorded in Tinybird causing unexpected event order
 All the events seem to have 00 seconds: Screenshot 2025-04-08 at 18.54.44.png This can result in an unexpected order of events: For this user we get the following events: Screenshot 2025-04-04 at 13.38.37.png The order is unexpected: why is disconnected wallet before connected wallet? Check if the disconnected wallet event has the same or older timestamp than the identified and connected wallet event Show event seconds in the activity feed "10:44:15 PM" P-1138 Privacy: Replace identifyAll with detect wallet, add detect event, Remove automatic GET /user call
 Currently we call  🚫 Most analytics tools do NOT automatically call  If you auto-identify users ( 
 So, until you call  ✅ TL;DR:
 Preferred flow: | 
    
| } | ||
| } | ||
| 
               | 
          ||
| // TODO: Refactoring => public this function as API | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, I'd like users to be able to call this after the install snippet (even right after initialization):
<script>
window.formo.identify()
</script>
The above should trigger the old identifyAll() behaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a2710ef    to
    ce105b4      
    Compare
  
    
No description provided.