[P-927] [P-953] [P-836] Limit identify call once per session, enable … #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracking on localhost, identify without address
P-953 On formo.so, no identify call is made
I expect a wallet address to be be included in the page_hit event if the visitor has Metamask installed, See https://github.com/getformo/sdk/blob/main/src/FormoAnalytics.ts#L94-L96 P-927 Too many identify events being sent
Too many identify events are being sent for each session. Currently each separate page view sends a new identify event. Can we have the SDK only send one identify event per session? P-836 SDK: Option to enable tracking on localhost
By default, disable tracking in localhost https://github.com/plausible/plausible-tracker?tab=readme-ov-file#usage On Hamza Market, they are seeing a lot of localhost events, which is not 'real' events: |
yosriady
reviewed
Feb 17, 2025
yosriady
requested changes
Feb 18, 2025
yosriady
reviewed
Feb 18, 2025
yosriady
reviewed
Feb 18, 2025
yosriady
reviewed
Feb 18, 2025
yosriady
reviewed
Feb 18, 2025
yosriady
reviewed
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tracking on localhost, identify without address