Skip to content

Conversation

@yosriady
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Aug 31, 2025

@yosriady yosriady requested a review from Copilot August 31, 2025 09:45
@yosriady
Copy link
Contributor Author

bugbot run

Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@yosriady yosriady marked this pull request as ready for review August 31, 2025 10:14
@yosriady yosriady requested a review from Copilot August 31, 2025 10:38
Copilot

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 1, 2025 05:53
@yosriady
Copy link
Contributor Author

yosriady commented Sep 1, 2025

bugbot run

Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 1, 2025 06:07
@yosriady
Copy link
Contributor Author

yosriady commented Sep 1, 2025

bugbot run

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the handling of duplicate empty identify events in the FormoAnalytics library. The main issue was that wallets without RDNS identifiers were not being properly deduplicated, leading to multiple identify events for the same wallet address.

  • Updated deduplication logic to handle wallets with empty/missing RDNS values
  • Enhanced logging for better debugging of identification flow
  • Modified session tracking to use address-only keys as fallback for empty RDNS

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/lib/version.ts Version bump to 1.19.10
package.json Version bump to 1.19.10
src/FormoAnalytics.ts Core fix for duplicate identify handling and enhanced logging

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cursor[bot]

This comment was marked as outdated.

@yosriady yosriady merged commit 0e5267e into main Sep 1, 2025
6 checks passed
@yosriady yosriady deleted the p-1352 branch September 1, 2025 06:18
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

🎉 This PR is included in version 1.19.10 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant