-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Handle duplicate empty identify events #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
bugbot run |
|
bugbot run |
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the handling of duplicate empty identify events in the FormoAnalytics library. The main issue was that wallets without RDNS identifiers were not being properly deduplicated, leading to multiple identify events for the same wallet address.
- Updated deduplication logic to handle wallets with empty/missing RDNS values
- Enhanced logging for better debugging of identification flow
- Modified session tracking to use address-only keys as fallback for empty RDNS
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/lib/version.ts | Version bump to 1.19.10 |
| package.json | Version bump to 1.19.10 |
| src/FormoAnalytics.ts | Core fix for duplicate identify handling and enhanced logging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🎉 This PR is included in version 1.19.10 🎉 |
No description provided.