fix: Fix duplicate connect events when multiple providers are available #116
Conversation
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with duplicate connect events when multiple wallet providers are available by implementing provider-specific identification and concurrency protection.
- Enhances event identification by adding provider RDNS to connect/disconnect events
- Implements concurrency protection to prevent race conditions during account changes
- Adds logic to only emit connect events from the active provider to avoid duplicates
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/utils/base.ts | Adds RDNS identifier to connect/disconnect event descriptors for provider differentiation |
| src/FormoAnalytics.ts | Implements comprehensive provider switching logic with concurrency protection and duplicate event prevention |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
bugbot run |
|
🎉 This PR is included in version 1.19.8 🎉 |
No description provided.