fix: only expose sats #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the confusion by the agent as it doesn't need to deal with different units.
bumi
reviewed
Jun 25, 2025
src/tools/nwc/get_balance.ts
Outdated
|
|
||
| // Convert millisats to sats | ||
| const convertedBalance = { | ||
| balance: Math.ceil(balance.balance / 1000), // Round up when converting millisats to sats |
Contributor
There was a problem hiding this comment.
hmm. isn't it better to round down in this case?
the millisats and the non-existent millisats I can not spend.
Collaborator
Author
There was a problem hiding this comment.
True, for the balance. Other things like fees I think rounding up makes sense still?
Collaborator
Author
There was a problem hiding this comment.
Update: I only rounded up fees
src/tools/nwc/get_balance.ts
Outdated
|
|
||
| // Convert millisats to sats | ||
| const convertedBalance = { | ||
| balance: Math.ceil(balance.balance / 1000), // Round up when converting millisats to sats |
Contributor
There was a problem hiding this comment.
would it help some robot if the name of the property is more descriptive balance_in_sats ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
This removes the confusion by the agent as it doesn't need to deal with different units.