New tickets #406
Merged
New tickets #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophieH29
reviewed
Feb 20, 2018
data/resources.json
Outdated
| "ticketsDetails": "Tickets grant access to all conference sections, coffee breaks, lunch and party. Accommodation is NOT included in the ticket price.", | ||
| "soldOut": "Sold out" | ||
| "soldOut": "You missed it", | ||
| "availableSoon": "Not available yet!", |
There was a problem hiding this comment.
might better to keep consistency: "notAvailableYet": "..."
| </div> | ||
| </div> | ||
| <div class="actions"> | ||
| <div class="sold-out" block$="[[ticket.soldOut]]"> |
There was a problem hiding this comment.
what does the 'block' attribute mean?
There was a problem hiding this comment.
sophieH29
approved these changes
Feb 20, 2018
CmoaToto
pushed a commit
to paug/android-makers-2019
that referenced
this pull request
Dec 24, 2018
* Initial commit * Add inDemand style * Restyle tickets block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile
Desktop