Add OWNERS files #8
Conversation
|
FYI: @RaphaelVogel @HeckEK |
|
@dimityrmirchev Where can I read the background info? Can you please link it, e.g. why do we have/call it |
|
@vlerenc Usually I am trying to follow the naming convention {repository_name}-reviewers and {repository_name}-approvers. As this repo is kind of special in the sense it is used as a base and named ".github" I did not find it suitable to use github-reviewers/approvers as a name. I copied the files from https://github.com/gardener/org/blob/main/OWNERS_ALIASES, maybe I should have left a comment in the files that assignments are synched from that place. Maybe we call them base-repo-reviewers/approvers or something else? WDYT? The aliases as described in https://www.kubernetes.dev/docs/guide/owners/#owners_aliases can be whatever we choose. We might use "foo" if that would make sense. Smaller repos usually use approvers/reviewers separation (example), but repositories with bigger communities can choose to separate these further (example). |
|
Thanks @dimityrmirchev. I wasn't aware of
Well, all I know is that I was confused when reading that alias. Repo admins (as in org members that are repo admins) and org owners (actual org owners that are sometimes confusingly also called org admins) are confusingly similar and therefore I would avoid that alias. But in general, I would also like to understand why we have it. I guess, because we need more people than the TSC, which is fine (one reason maybe). And I guess, because @oliver-goetz is running Prow, which is also fine (another reason maybe). However, I actually don't know. Without documentation/background, I cannot understand the meaning and therefore I cannot review this PR. |
|
I understand your points. The main question is probably "Who will be responsible for the maintenance of this repository?". I did not see a Would that be TSC or/and some other team 🤔 |
There was a problem hiding this comment.
This repo includes the front page of the Github Gardener organization. Thus, people who are responsible for Gardener marketing and those who are able to write proper English texts could be helpful as reviewers.
Clearly, we did not define such responsibilities yet and we have just started to define Gardener Community Roles. As an initial version Dimitar's proposal is fine with me.
/lgtm
This PR prepares the repository for migration to prow.
Part of gardener/org#3
OWNERS files are copied from the org repo.
@rfranzke, @ScheererJ, @timebertt, @vlerenc, @oliver-goetz, @timuthy please review and make adjustments if necessary.