Make command string shorter for exec #217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have too many hosts, given command string becomes so long that 'exec' function cannot handle it properly. It's a little bit inefficient but works correctly even if you have many(>1000) hosts, especially for stacked grapher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have really many hosts and stack graph is not generated with no reason,
too long command could be one reason.
When we have too many hosts, given command string to (my_)passthru
becomes so long(in my case, >2MBs) that 'exec' function cannot handle it properly.
Saving command in the file seems a little bit inefficient but works correctly even if
you have many(>1000) hosts, especially for generating stacked graph.