Use this.props.state as previousState for first action response #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Don't accept this yet. I found the root of the problem. this.props.previousState starts out as null. |
Author
|
There we go. :) |
select when state is truthy
Owner
There was a problem hiding this comment.
This is incorrect. Component can receive new props in componentWillReceiveProps so it is wrong to calculate anything based on props in the constructor and cache it.
Owner
There was a problem hiding this comment.
In general, this seems to give you the wrong semantics. You are making it look like the previous state is the current state for the first action. However what really happens is that it doesn’t exist.
gaearon
added a commit
that referenced
this pull request
Feb 3, 2016
Owner
|
Thank you again for the PR and taking a look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27.