MERGE rather than CREATE in addResourceToWorkspaceFolder #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
approved these changes
Nov 13, 2025
Contributor
twrichards
left a comment
There was a problem hiding this comment.
if this is the problem, looks like it's been the case for 4 years
Contributor
Author
|
Replaced by #428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
There is something strange going on with uploads to certain workspaces on PROD - we get an error like this:
org.neo4j.driver.v1.exceptions.ClientException: Node(123) already exists with labelWorkspaceNodeand propertyid= 'id123'The CREATE within this query should only ever be executed once for each nodeId, but the above error is making me wonder whether somehow it is being executed twice.
I don't want to leave this change in permanently, but in the short term it could help unblock uploads to these workspaces, and I think seems harmless.
How to test
Deploy to PROD, check if it fixes issues with the relevant workspaces