-
Notifications
You must be signed in to change notification settings - Fork 4
Fixed error in Post + Permissions, need integration-tests #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
app/controllers/posts_controller.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align the parameters of a method call if they span more than one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 42, 3 is not aligned with if at 36, 4
Tab detected.
|
I got stuck with the: I started working with VIM apparently Hound thinks my indentation is totally crazy. It does not look like this for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 40, 3 is not aligned with if at 34, 4
Tab detected.
|
You need to fix your vim config. Mine is a good start. Never use tabs in your cod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align the elements of a hash literal if they span more than one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align the elements of a hash literal if they span more than one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henrikssn @jforberg
Anyway to fix this with vim-config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align the elements of a hash literal if they span more than one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expression at 6, 56 should be on its own line.
|
@fsek/admins OK to merge? |
|
LGTM Ship it! |
Fixed error in Post + Permissions
|
This PR was deployed to Production. Reference: cdff1a2 |
Fixes #148, more integration-test needed. WIP