Skip to content

Conversation

@davidwessman
Copy link
Member

Fixes #148, more integration-test needed. WIP

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 42, 3 is not aligned with if at 36, 4
Tab detected.

@davidwessman
Copy link
Member Author

I got stuck with the:
https://github.com/fsek/web/blob/master/spec/features/login_visit_election.rb
far too long. Cannot get it right with the JS-testing, and when I gave up on that I couldn't get it to work like before...

I started working with VIM apparently Hound thinks my indentation is totally crazy. It does not look like this for me.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 40, 3 is not aligned with if at 34, 4
Tab detected.

@henrikssn
Copy link
Contributor

You need to fix your vim config. Mine is a good start. Never use tabs in your cod.

www.github.com/henrikssn/.vim

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the elements of a hash literal if they span more than one line.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the elements of a hash literal if they span more than one line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrikssn @jforberg
Anyway to fix this with vim-config?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the elements of a hash literal if they span more than one line.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expression at 6, 56 should be on its own line.

@davidwessman
Copy link
Member Author

@fsek/admins

OK to merge?

@henrikssn
Copy link
Contributor

LGTM

Ship it!

davidwessman added a commit that referenced this pull request Apr 21, 2015
Fixed error in Post + Permissions
@davidwessman davidwessman merged commit cdff1a2 into master Apr 21, 2015
@ghost
Copy link

ghost commented Apr 21, 2015

This PR was deployed to Production. Reference: cdff1a2

@davidwessman davidwessman deleted the FixPostError branch April 21, 2015 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Utskotten trasiga

4 participants