send email to bilf on new booking (#450) #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should resolve #450 |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
Surely I've fixed all the bugs now. Looks green on my end idk. |
maffe03
requested changes
Dec 22, 2025
Member
maffe03
left a comment
There was a problem hiding this comment.
Thanks for the help!
I think it might be better to duplicate some code rather than mess with the User_DB objects as they are scary and might do Database Stuff™, but overall it's good!
mailer/bilf_mailer.py
Outdated
| msg["Subject"] = "Ny kollegie-bilbokning / New council car booking" | ||
|
|
||
| # This will surely be super bad | ||
| fake_user = User_DB( |
Member
There was a problem hiding this comment.
Probably better to just create a new send_mail_to_adress function instead which takes in an EmailStr instead of User_DB
mailer/bilf_mailer.py
Outdated
| html = html.replace("{{ booking.time }}", time_string) | ||
|
|
||
| if booking.council is not None: | ||
| html = html.replace("{{ booking.council_en }}", booking.council.name_en) |
Member
There was a problem hiding this comment.
Probably unnecessary but maybe escape these as well? This is technically (admin) user input.
fix with new mailer function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surely this well tested code doesnt break anything.
Pls especially double check mailer/bilf_mailer.py line 51