Update image after snap #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #861 +/- ##
==========================================
- Coverage 99.86% 99.79% -0.07%
==========================================
Files 8 8
Lines 1477 1481 +4
==========================================
+ Hits 1475 1478 +3
- Misses 2 3 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Man I really gotta fix that coverage thing. Failing for missing 1 line in tests is annoying |
|
I suppose we really should be adding tests for all new code. It's forces testing, and it's easy to be lazy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This should address the long delay in updating images after a snap, allowing the removal of line 129 (which apparently isn't doing what I thought it should):
https://github.com/home-assistant/core/blob/45fec1d4048c72ef94df027154ecf7bf69c21c84/homeassistant/components/blink/camera.py#L128-L130
and reduce the number of update calls made to Blink.
Related issue (if applicable): fixes #
Checklist:
toxrun successfully PR cannot be meged unless tests pass