Make fricas installation relocatable #197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tallation relocatable
mkoeppe
added a commit
to passagemath/passagemath
that referenced
this pull request
May 18, 2025
|
On Sun, May 18, 2025 at 10:40:47AM -0700, Matthias Köppe wrote:
Instead of hard-coding the `exec_prefix` in the installed `fricas` script, obtain it from the invocation of the script.
I have some doubts about this patch. First, current design allows
you to easily customize behaviour: you can prepend to 'fricas'
script your own script which computes desired FRICAS_PREFIX
(or set FRICAS_PREFIX in environment before invoking 'fricas'
script). You remove this possibility of customization, replacing
it by fixed behaviour, that is depending on relative positions.
Second, FriCAS in principle runs on quite large variety of operating
systems. My understanding was that some systems do not set "$0"
to full pathname.
Extra remark1: 'resolvelinks.sh' tries to produce relative path
when given a relative path as input. But the only supported
seting of FRICAS is absolute.
Extra remark2: FRICAS_PREFIX exists to support installers on
Mac OSX. I do not know if it is used in current packages,
but if used your change can in principle break them.
…--
Waldek Hebisch
|
mkoeppe
commented
May 28, 2025
| echo 'exec_prefix=$$(resolvelinks "$$0")' >> '${COMMAND}'.tmp | ||
| echo 'exec_prefix=$${exec_prefix%/*}' >> '${COMMAND}'.tmp | ||
| echo 'exec_prefix=$${exec_prefix%/*}' >> '${COMMAND}'.tmp | ||
| echo 'exec_prefix=$$(cd $$exec_prefix && pwd -P)' >> '${COMMAND}'.tmp |
There was a problem hiding this comment.
note that here I make the exec_prefix absolute.
Likely it is used exactly to relocate the prebuilt binary package, and they would simply not have to set this variable any more. |
I can only note that the script was in use in Sage for a very long time, including when Cygwin was still supported. The script is so long because it achieves its goals even when "$0" is not the full pathname. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding the
exec_prefixin the installedfricasscript, obtain it from the invocation of the script.The portable shell code for this also handles the situation when the script is invoked via symlinks.