feat: role replication #26845
Merged
feat: role replication #26845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rtdany10 i waited 10 years for this function haha! excellent! |
|
Could you add a more detailed description to the PR, along with some real world use cases? If I understand the code correctly, this creates a new Role and Custom DocPerms with all permissions from the existing role? Maybe even add some explanation within the doctype. |
|
@federicocalvo got tired of creating user-based roles that was painstakingly similar to that of existing roles, ended up creating a quick functionality. :) @barredterra sorry, I've updated the PR description. Yes, we can add a description in the doctype itself. I'll send a PR in the evening hopefully. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Role Replication allows users to easily replicate/extend role based access.
Often, we might have to give access to a user which is very similar to an existing role but with slight variation. For example, a purchase executive might not need all the access granted to Purchase User role. In such cases, we have to create a new role and then assign the access to each doctype individually via Role Permission Manager. This is hectic and takes a lot of time.
For example, to create a role that would have access to create a Purchase Order, you will need to grant access to:
and the list goes on, based on the link fields you have in the doctype and code based dependency, fetch from etc.
On the contrary, it is easier to have a another role with same access as Purchase User and then strip it down based on use case. Role Replication allows you to replicate the role with it's access rights.