Skip to content

Fix: Sometimes index === -1 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2019
Merged

Fix: Sometimes index === -1 #248

merged 1 commit into from
Oct 30, 2019

Conversation

@emilsgulbis
Copy link
Contributor

@emilsgulbis emilsgulbis commented Oct 7, 2019 •
edited
Loading

Sometimes when mouse-overing container, i got vendors.app.js:8427 Uncaught TypeError: Cannot read property 'xPos' of undefined that is caused by -1 index

Explanation About What Code Achieves:
  • To disable -1 index tooltip when hovering container
Screenshots/GIFs:

Screenshot 2019-10-07 at 14 39 07

@emilsgulbis
Fix: Sometimes index === -1
f85daa3 
Sometimes when mouse-overing container, i got `vendors.app.js:8427 Uncaught TypeError: Cannot read property 'xPos' of undefined` that is caused by `-1` index
@coveralls
Copy link

coveralls commented Oct 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 138

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.158%
Totals Coverage Status
Change from base Build 136: 0.0%
Covered Lines: 29
Relevant Lines: 62
💛 - Coveralls

@bennylut
Copy link

bennylut commented Oct 28, 2019

I am also having this issue - a workaround that I found was to disable pointer events in the relevant components:

.chart-container {
    pointer-events: none;

    .chart-draw-area {
        pointer-events: all;

        .y.axis {
            pointer-events: none;
        }

        .x.axis {
            pointer-events: all;
        }
    }
}

@scmmishra scmmishra merged commit f06d0c7 into frappe:master Oct 30, 2019
@willjosefi
Copy link

willjosefi commented Dec 16, 2019

hi, is this merge didn't publish yet?
on npmjs i just can see the 1.3.0 version, which contains that bug :(
is there a way to use the updated version?

@bmuller bmuller mentioned this pull request Apr 30, 2020
Closed
@scmmishra scmmishra mentioned this pull request Jun 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@scmmishra scmmishra scmmishra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emilsgulbis @coveralls @bennylut @willjosefi @scmmishra