Skip to content

Conversation

@MrCroxx
Copy link
Member

@MrCroxx MrCroxx commented Sep 20, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #726

@MrCroxx MrCroxx added this to the v0.11 milestone Sep 20, 2024
@MrCroxx MrCroxx self-assigned this Sep 20, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) September 20, 2024 07:10
@MrCroxx MrCroxx merged commit f1490da into main Sep 20, 2024
19 checks passed
@MrCroxx MrCroxx deleted the xx/rename branch September 20, 2024 07:18
@codecov
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer/src/hybrid/builder.rs 20.00% 8 Missing ⚠️
foyer-storage/src/store.rs 50.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/store.rs 73.90% <50.00%> (-0.83%) ⬇️
foyer/src/hybrid/builder.rs 92.82% <20.00%> (-3.67%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

refactor: rename buffer_threshold to buffer_pool_size

2 participants