Skip to content

Conversation

@MrCroxx
Copy link
Member

@MrCroxx MrCroxx commented Sep 6, 2024

Signed-off-by: MrCroxx [email protected]## What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

  • Bump rust toolchain to 1.81.0
  • Replace allow with expect and warn on future allow usages.
  • Remove trace feature for foyer-bench.
  • Upgrade nightly toolchain to nightly-2024-07-19

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

@MrCroxx MrCroxx added this to the v0.11 milestone Sep 6, 2024
@MrCroxx MrCroxx self-assigned this Sep 6, 2024
@codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer-bench/src/main.rs 66.11% <ø> (+0.23%) ⬆️
foyer-common/src/event.rs 0.00% <ø> (ø)
foyer-common/src/metrics.rs 97.91% <ø> (+0.88%) ⬆️
foyer-memory/src/eviction/s3fifo.rs 94.26% <ø> (ø)
foyer-memory/src/generic.rs 90.92% <ø> (+0.01%) ⬆️
foyer-storage/src/engine.rs 35.65% <ø> (ø)
foyer-storage/src/large/flusher.rs 95.32% <ø> (-0.03%) ⬇️
foyer-storage/src/large/reclaimer.rs 85.48% <ø> (-0.61%) ⬇️
foyer-storage/src/large/recover.rs 90.29% <ø> (-0.55%) ⬇️
foyer-storage/src/large/scanner.rs 75.72% <ø> (ø)
... and 6 more

... and 6 files with indirect coverage changes

@MrCroxx MrCroxx merged commit fec88f0 into main Sep 6, 2024
@MrCroxx MrCroxx deleted the xx/expect branch September 6, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants