Simplified AbstractJavaSourceMemberHolder#addInterface(java.lang.String)
#261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gastaldi
commented
Oct 15, 2022
- Fixes Wrong code generated when extending interface with another that has the same name #259
|
@jsenko can you check if this fix works for you? Thanks! |
53d5c64 to
607fab4
Compare
AbstractJavaSourceMemberHolder#addInterface(java.lang.String)
|
Hi @gastaldi , it works now! Thanks for the quick response. Would you consider releasing 2.26.1 in the near future? |
|
Sure, just waiting for a review from @lincolnthree before proceeding 😉 |
607fab4 to
2ba52d8
Compare
|
@jsenko I pushed another change, can you let me know if that still works for you? |
7fd42a9 to
cf3cd91
Compare
…rHolder#addInterface(java.lang.String) - Fixes #259
cf3cd91 to
89b8bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.