fixed a call to chokidar in watch plugin #155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed a call to chokidar. Callback to chokidar needs parameters order to be 'status', 'file'"
|
@DYNAMIC1 Can you point into the direction of documentation for that? Quick check on chokidar readme didn't help. |
|
This PR claims that callback signature is actually different: https://github.com/foreverjs/forever-monitor/pull/116/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a call to chokidar. Callback to chokidar needs parameters order to be 'status', 'file'", but in the file the order is reversed.
I found this issue because when I run forever it prints:
"restarting script because change changed"
instead of showing the actual file that changed.