Skip to content

Conversation

@hmoog
Copy link

@hmoog hmoog commented Feb 27, 2017

The parameters are in the wrong order so that "stat-property" contains the file name and the "file-property" contains the stat

The parameters are in the wrong order so that "stat-property" contains the file name and the "file-property" contains the stat
@agauniyal
Copy link

@indexzero would you mind merging some of the essential Pull Requests opened in this repo. I understand if there is less time to look after this rep but some are minimal yet essential changes that would help us a lot 👍

@kibertoad
Copy link
Contributor

@hmoog Could you please link to the documentation of said callback's signature? There are contradicting PRs addressing this issue, I wonder which way is the correct one.

@levity
Copy link

levity commented Jan 10, 2019

You can see that in the second example here in chokidar's README that the file path is the second argument.

@kibertoad
Copy link
Contributor

@levity But there doesn't seem to be an example for all branch?..

@levity
Copy link

levity commented Jan 10, 2019

This is what I see:

paulmillr_chokidar__a_neat_wrapper_around_node_js_fs_watch___fs_watchfile___fsevents_

Maybe I should have said "first example"; I was counting code boxes 😅

@kibertoad
Copy link
Contributor

Thank you! Missed that part. Then this PR should be updated to reference event and path as is the case in the example.

@andyburke
Copy link

I understand wanting some nice names, but could this be merged since it addresses a bug, and then a followup PR could rename things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants