fix(wget_agent): add FOSSOLOGY_SKIP_CHOWN for NFSv4 compatibility #3145
Conversation
Signed-off-by: sarika-03 <[email protected]>
|
Hey @shaheemazmalmmd |
|
Hey @sarika-03, This change looks like a pragmatic workaround for environments where mounted volumes disallow chown (NFS, some PVs, bind mounts with UID/GID mismatches), but it’s important to be explicit about what it does and what it does not:
Risks: silently ignoring chown failures can mask real permission problems later at runtime and can create inconsistent behaviour between deployments. So if I take this as an workaround: There are better ways to solve this without adding suppressors in the code. If you have such requirement for your deployment, Maybe we can discuss on better solutions? |
|
Hi @Kaushl2208 . I agree we need a better approach. Would you prefer:
Happy to revise based on your preference. What direction would you recommend? Thanks for the guidance! 🙏 |
Problem
Upload fails on NFSv4 volumes where
chown()returnsOperation not permitteddue to NFSv4 identity mapping restrictions.Error:
This prevents FOSSology deployment in Docker Swarm environments using NFS storage.
Solution
Added optional
FOSSOLOGY_SKIP_CHOWNenvironment variable to allow uploads to continue whenchown()fails.Changes Made
src/wget_agent/agent/wget_agent.c
Modified 3 chown() call sites in DBLoadGold() function:
docker-compose.yml: Added environment variable to scheduler and web servicesBehavior
FOSSOLOGY_SKIP_CHOWN** (default): Original behavior, backward compatibleFOSSOLOGY_SKIP_CHOWN=true**:chown()failure logs WARNING, upload continues##Testing
1 . Restart containers
docker-compose down
docker-compose up -d
2 . Verify env variable
docker exec fossology_scheduler_1 env | grep FOSSOLOGY_SKIP_CHOWN
# FOSSOLOGY_SKIP_CHOWN=true
3. Create & upload test file
echo "NFSv4 Fix Test - $(date)" > ~/Desktop/test.txt
4.Check logs after upload
docker logs fossology_scheduler_1 2>&1 | grep -i chown | tail -20
5.Result - Upload succeeds
Fixes #3129