refactor(api): introduce error handling #2598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use custom exceptions for handling HTTP error status codes instead of writing long if-else ladders. This makes code cleaner and easier to maintain. At the same time, make small changes to make code more robust. Signed-off-by: Gaurav Mishra <[email protected]>
Also fix typos in unit test and relevant API Documentation texts. Signed-off-by: Gaurav Mishra <[email protected]>
c21b6e2 to
c10906d
Compare
shaheemazmalmmd
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use custom exceptions for handling HTTP error status codes instead of writing long if-else ladders. This makes code cleaner and easier to maintain.
At the same time, make small changes to make code more robust.
Changes
Create new exceptions for REST API and throw them in Controllers instead of writing long if-else ladders.
How to test
Test REST endpoints.