fix(PSR-12): closing ?> tag MUST be omitted #2594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc-Etienne Vargenau <[email protected]>
Signed-off-by: Marc-Etienne Vargenau <[email protected]>
|
@vargenau Thank you for the contribution. |
Create endpoints for CX operations (email, ecc, keywords, etc.) and use common functions in CopyrightController. Signed-off-by: Gaurav Mishra <[email protected]>
Info on 88d04ec BREAKING CHANGE: Response for `/uploads/{id}/item/{itemId}/copyrights` endpoint `#/components/schemas/GetFileCopyrights` parameter `copyright_count` is renamed to `count` to enable reusability by other CX endpoints. Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Shaheem Azmal M MD <[email protected]>
|
Hey @vargenau , looks like you've merged with master branch instead. Please use |
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
|
Sorry, I created a mess when tying to squash. I have created a new pull request #2599 Let us close this one. |
|
Merged #2599, thus closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PSR-12:
All PHP files MUST end with a non-blank line, terminated with a single LF.
The closing ?> tag MUST be omitted from files containing only PHP.
Changes
Remove closing ?> tag